Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.0: Handle invalid responses #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TysonAndre-tmg
Copy link

  • Add function names so it's obvious where this error originates from
  • Only iterate over the responses if the response is actually an array. Ignore other types such as strings/objects
  • Stop using for (var key in array)

npm test passes in Node.js 8+ and with mocha for browser testing. GLOBAL is a deprecated then removed alias of global

- Add function names so it's obvious where this error originates from
- Only iterate over the responses if the response is actually an array.
  Ignore other types such as strings/objects
- Stop using `for (var key in array)`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant