Fix sorting willplay:yes by playtime
#1280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1279
This was caused by #1265. Before that, the query did a
left jointowishlists wland added awhere wl.gameid is not null. In #1265, I turned it into a subselect,gameid in (select gameid from wishlists where userid = '$curuser').This improved performance, and usually works, but when we join to
gametimes_mv,gameidis ambiguous betweengametimes_mv.gameidandgameRatingsSandbox0_mv.gameid.Using
games.idensures that we're using an unambiguous field.