Skip to content

Make game searches do an inner join to gameRatingsSandbox0_mv #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
Merged

Make game searches do an inner join to gameRatingsSandbox0_mv #1273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions www/searchutil.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,15 +285,8 @@ function doSearch($db, $term, $searchType, $sortby, $limit, $browse)
$baseWhere = "";
$groupBy = "";
$baseOrderBy = "";
if ($browse && ($sortby == "" || $sortby == "ratu" || $sortby == "ratd" || $sortby == "rcu")) {
// when sorting by highest/lowest/most ratings, we can optimize by
// fetching the top N from the gameRatingsView
$tableList = "games
join ".getGameRatingsView($db)." on games.id = gameid";
} else {
$tableList = "games
left join ".getGameRatingsView($db)." on games.id = gameid";
}
$tableList = "games
join ".getGameRatingsView($db)." on games.id = gameid";
$matchCols = "title, author, `desc`, tags";
$likeCol = "title";
$summaryDesc = "Games";
Expand Down