Skip to content

Improve "IFDB Recommends" performance, adding $count_all_possible_rows parameter to doSearch #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 3, 2025
Merged

Improve "IFDB Recommends" performance, adding $count_all_possible_rows parameter to doSearch #1265

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cb16a72
searchutil.php: Add $count_all_possible_rows parameter to doSearch
alice-blue Jan 19, 2025
1e208ef
ifdb-recommends.php: Use $count_all_possible_rows parameter in call t…
alice-blue Jan 19, 2025
404520b
review: Use $count_all_possible_rows parameter in call to doSearch
alice-blue Jan 19, 2025
3a133f1
search: Use $count_all_possible_rows parameter in call to doSearch
alice-blue Jan 19, 2025
f91e3af
editgame: Use $count_all_possible_rows in call to doSearch
alice-blue Jan 19, 2025
3342cf3
length($rows) --> count($rows) (to get rid of fatal error)
alice-blue Jan 19, 2025
ea64674
Improve logged-out IFDB Recommends search performance
dfabulich Jan 22, 2025
27f50d3
Improve logged-in IFDB Recommends search performance
dfabulich Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion www/components/ifdb-recommends.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ function sortBySortorder($a, $b)
$sortby = "ratu"; // Sort the highly rated games to the top of the results.
$maxpicks = 12; // Get the first twelve results. (We want extras so we're not always displaying the same games.)
$limit = "limit 0, $maxpicks";
$browse = 0;
$browse = 1;
$count_all_possible_rows = false;


Expand Down