Skip to content

Conversation

@dfabulich
Copy link
Collaborator

Fixing #1256 seems to have made some buried games appear on the first page of Browse results. Let's just suppress the warning on the first page of browse results.

@dfabulich dfabulich merged commit 68e1d11 into main Jan 18, 2025
@salty-horse
Copy link
Collaborator

salty-horse commented Jan 18, 2025

I don't fully understand what this means. Can you provide a screenshot of this warning, and explain why these games should not be visible?

Also, IMO it's cryptic enough to merit a comment in the code.

@dfabulich
Copy link
Collaborator Author

dfabulich commented Jan 20, 2025

I've added a comment in 8f09857.

Here's a screenshot below of the banner. ("Some results were hidden. See all results")

Here's an example buried game, Necromancer. https://ifdb.org/viewgame?id=b36l51ogn147x0iv Necromancer was buried due to coordinated vote manipulation. You can still see the banner if you search for Necromancer. https://ifdb.org/search?searchbar=necromancer

I'm hiding the banner on the first page of the Browse Games page, because the banner would be too prominent in that case. The goal of the "bury game" feature is to silently not recommend games, but having the banner at the top of the first page of the "Browse Games" page draws too much attention to the banner.

image

@dfabulich
Copy link
Collaborator Author

It turns out that I didn't actually need to do this, because buried games were only appearing in the top 100 because of #1263. Now that that's fixed, no buried games naturally appear on the first page of Browse Games.

But, I still want to suppress the banner on the first page of Browse Games, just in case this crops up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants