Remove invalid swift-stdlib-tool invokation parameters #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 24, 2023 18:23
…rs which Buck interprets as a broken sdk folder. This PR adds a filter that ignores AssetRuntime folders.
| @@ -135,8 +135,6 @@ public class AppleBundle extends AbstractBuildRule | |||
| @AddToRuleKey private final Tool codesign; | |||
|
|
|||
| @AddToRuleKey private final Optional<Tool> swiftStdlibTool; | |||
|
|
|||
| @AddToRuleKey private final Optional<Tool> bitcodeStripTool; | |||
There was a problem hiding this comment.
Do you know if the concurrency .dylib is added already without bitcode?
andre-alves-ifood
approved these changes
Mar 2, 2023
donPain
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change submitted to apple/swift introduced a filter to reject invalid parameters:
swiftlang/swift@2ac4283
The removed parameters aren't valid at least since our current Xcode version (14.2)