2300 tagging strategy or moment from category page #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request with us! Be sure to follow our Pull Request Practices. Let us know if you have any questions on Slack. |
…github.com/LucasKay64/ifme into 2300_strategy_or_moment_from_category_page
julianguyen
reviewed
Nov 27, 2024
| category = Category.friendly.find_by(slug: params[:category]) | ||
| ids << category.id if category | ||
| end | ||
| ids |
There was a problem hiding this comment.
Can you write unit tests for this?
julianguyen
reviewed
Nov 27, 2024
| checked = @strategy.categories.include?(item) | ||
|
|
||
| if params[:category].present? && @strategy.new_record? && !checked | ||
| checked = item.slug == params[:category] |
There was a problem hiding this comment.
Can you write unit tests for this?
julianguyen
requested changes
Nov 27, 2024
|
Thank you! Sure thing. Will do. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the ability to create a new strategy or moment from a concrete category page with tagging of the related category in the form for creating that new strategy or moment.
More Details
Added buttons aligned right to the title. They take the user to the form for creating a new strategy or moment. The tagged category from which the user clicked the buttons is stored in the URL query string and is read by the corresponding form. Also added some styling for mobile responsiveness.
The new @page_new_buttons handles multiple buttons for any title on any page for further use in the future although if one adds too many buttons, new CSS media query will be required to add as well.
Screenshots
Corresponding Issue
#2300