Fix user seeds not populating from pwned_password validation
#2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ignore validations when creating
Userin the seed file to match the sample users on https://github.com/ifmeorg/ifme/wiki/Installation#testing-accountsMore Details
Since my implementation of #1935 , when the pwned password list database updates, more passwords will be checked to the data breach dump which prevents users from creating a password that's already been found in a breach.
Since these are just test users which you can find on a public Wiki page in plaintext, it doesn't matter that the password is
passwordso I decide to ignore the validations so we can seed those users for testing purposes.Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!