-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Storybook build to our Circle CI configuration #2163
Comments
Will give it a try |
That would be great, thank you, @cristianmedeiros! |
@cristianmedeiros are you working on this? |
Hi Rajat, yes, slowly, but yes
…On Mon, Oct 17, 2022 at 11:13 AM Rajat Tomar ***@***.***> wrote:
@cristianmedeiros <https://github.com/cristianmedeiros> are you working
on this?
—
Reply to this email directly, view it on GitHub
<#2163 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAIAT6AN73ZSYLB3YHB6TTWDVNIHANCNFSM6AAAAAARAYLLA4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Ohh ok! just wanted to confirm. Thanks for confirming @cristianmedeiros !😊 |
hi @rajat-tomar I probably won't finish it today to hacktoberfest, do you want to assing this issue for you? |
It's okay @cristianmedeiros, Hacktoberfest is anyways ending now. You should give it one more shot. For now, I'm working on some other priority projects. Just let me know if you need any help regarding this else I'll be happy to pick this up this weekend. |
this issues seems to be inactive and i'm assuming is available. will work on this now. |
Description
Let's add a Storybook build to our Circle CI configuration. We need to verify that merges to our repo do not break the Storybook build. If there are changes to files in
/client
, we want to verify that the Storybook build passes before a PR is mergeable.Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.
Check out our Picking Up Issues guide if you haven't already!
The text was updated successfully, but these errors were encountered: