[Improvement][api] https://github.com/datavane/datasophon/issues/364 Improvement #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md file 完善
datasophon
reviewed
Oct 8, 2023
| InetAddress ip = InetAddress.getLocalHost(); | ||
| return ip.getHostAddress(); | ||
| } catch (UnknownHostException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
use exists api to get hostname
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
主机连接校验与主机Agent分发时，若分发节点与主节点在同一台机器上，无需进行校验和远程分发
Brief change log
改进主要是根据当前manage主机的ip来进行判断，如果运行的流程ip和当前manage主机的ip相同，就不进行进行校验和远程分发，而是直接使用调用本地shell脚本的方式来进行分发
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contains incompatible changes, you should also pull request the documentation to
https://github.com/datasophon/datasophon-website