Replace if with multiple comparison with case
#274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `if` statements with a `case` statement to address
`Style/MultipleComparison` offense. This change improves performance by
speeding up execution in most cases, with a slight trade-off in speed
for `:now` checks.
The majority of spec suite cases involve the current date, making this
optimization beneficial.
```
Comparison (now):
if...else: 14708814.2 i/s
case: 13579441.0 i/s - 1.08x (± 0.00) slower
Comparison (today):
case: 14638473.0 i/s
if...else: 13331314.1 i/s - 1.10x (± 0.00) slower
Comparison (else):
case: 14111134.0 i/s
if...else: 12212282.1 i/s - 1.16x (± 0.00) slower
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
ifstatements with acasestatement to addressStyle/MultipleComparisonoffense. This change improves performance by speeding up execution in most cases, with a slight trade-off in speed for:nowchecks.The majority of spec suite cases involve the current date, making this optimization beneficial.