Use default type cast for recorded_at
#271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `recorded_at` was consistently returned in UTC format, with the reason for this decision not explicitly documented in the commit history. This commit modifies the behavior to use the application's configured timezone for `recorded_at`, aligning with the default type cast for timestamp fields. This adjustment ensures that timestamp data is presented in a more intuitive format for users, potentially enhancing user experience and data interpretation. ### Before: ``` Activity.last.history.first.recorded_at => 2024-01-05 14:40:18.656918 UTC ``` ### After: ``` Activity.last.history.first.recorded_at => Fri, 05 Jan 2024 15:40:18.656918000 CET +01:00 ```
tagliala
added a commit
that referenced
this pull request
Feb 27, 2024
This method was used in features that were removed (#268 and #271) and the reason for converting ts values selected from the timeline query is not explicitly documented in the commit history and appears to be redundant (they are already timestamps) After conducting manual tests on the `usec`s, it was determined that the issue reported in issue #32 is no longer valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
recorded_atwas consistently returned in UTC format, with the reason for this decision not explicitly documented in the commit history.This commit modifies the behavior to use the application's configured timezone for
recorded_at, aligning with the default type cast for timestamp fields.This adjustment ensures that timestamp data is presented in a more intuitive format for users, potentially enhancing user experience and data interpretation.
Before:
After: