Fix predecessor of current record #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
force-pushed
the
bugfix/201-fix-pred-on-current-record
branch
2 times, most recently
from
bd394e0 to
3f1622f
Compare
tagliala
force-pushed
the
bugfix/201-fix-pred-on-current-record
branch
from
3f1622f to
5df11d5
Compare
Order of history on current record was not correct, so `pred` returned the second element of the history This commit uses `reverse_order` to allow Active Record to properly reorder history. This change replaces ```sql ORDER BY lower(validity) ASC, upper(validity) DESC ``` with a better ```sql ORDER BY lower(validity) DESC ``` and also uses `second` instead of `offset(1).first` for clarity Fix #201
tagliala
force-pushed
the
bugfix/201-fix-pred-on-current-record
branch
from
5df11d5 to
0646270
Compare
tagliala
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order of history on current record was not correct, so
predreturnedthe second element of the history
This commit uses
reverse_orderto allow Active Record to properlyreorder history. This change replaces
with a better
and also uses
secondinstead ofoffset(1).firstfor clarityFix #201