Bugfix/fix historical relation 181 #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
force-pushed
the
bugfix/fix-historical-relation-181
branch
from
070ac7d to
a801f63
Compare
gridanjbf
reviewed
Nov 9, 2022
Starting from Rails 6.0, read_attribute will use the memoized `primary_key` if it detects that the attribute name is `id`. Since the `primary key` may have been changed to `hid` in this case because of `find` overload, the new behavior may break relations where `id` is still the correct attribute to read for foreign key Fix: #181
tagliala
force-pushed
the
bugfix/fix-historical-relation-181
branch
from
4d3c60b to
0f76b07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.