Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7.1 edge support #180

Merged
merged 3 commits into from
Oct 8, 2022
Merged

Rails 7.1 edge support #180

merged 3 commits into from
Oct 8, 2022

Conversation

tagliala
Copy link
Member

@tagliala tagliala commented Oct 1, 2022

No description provided.

@tagliala tagliala changed the title Feature/rails 71 support Rails 7.1 support Oct 1, 2022
@tagliala tagliala changed the title Rails 7.1 support Rails 7.1 edge support Oct 1, 2022
@tagliala tagliala force-pushed the feature/rails-71-support branch 6 times, most recently from 8abec02 to 46516d1 Compare October 8, 2022 13:00
- Rails 7.0 deprecated the `direct_descendants` method in favor of `subclasses`
- Ruby 3.1 added native `subclasses` support to `Class`

Ref #179

Ref:
- Alias direct_descendants as subclasses: rails/rails@8f8aa85 rails/rails#39505
- Filter reloaded classes in Class#subclasses and Class#descendants core exts: rails/rails@1aa2463 rails/rails#46144
This works with either `adapter.materialize_transactions` before
the savepoint creation or by skipping the savepoint entirely and
reverting the migration by raising `ActiveRecord::Rollback`

Close #179

Ref: rails/rails@57bc28f rails/rails#44576
Ref:
- Move dbconsole logic to Active Record connection adapter: rails/rails@4bcb8e4 rails/rails#46093
- Use adapter_class instead of connection_class for adapters: rails/rails@5bb357f rails/rails#46166
@tagliala tagliala force-pushed the feature/rails-71-support branch from 46516d1 to d1e8729 Compare October 8, 2022 13:17
@tagliala tagliala marked this pull request as ready for review October 8, 2022 13:21
@tagliala
Copy link
Member Author

tagliala commented Oct 8, 2022

Merging because this also fixes issue with Ruby 3.1 and Rails 7.0

@tagliala tagliala merged commit 76a3540 into master Oct 8, 2022
@tagliala tagliala deleted the feature/rails-71-support branch October 8, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant