Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch BatchEnumerator class #178

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Conversation

tagliala
Copy link
Member

@tagliala tagliala commented Oct 1, 2022

Fix #177

@tagliala tagliala force-pushed the bugfix/fix-in-batches-support branch from e0a099a to ec4ae5b Compare October 1, 2022 10:07
Use `hid` instead of `id` when iterating on history models

Use `@relation` instead of the `relation` attribute reader to use the
same patch on legacy Rails versions

Fix #177
@tagliala tagliala force-pushed the bugfix/fix-in-batches-support branch from ec4ae5b to 10db0c4 Compare October 3, 2022 08:11
@tagliala tagliala marked this pull request as ready for review October 3, 2022 08:11
@tagliala
Copy link
Member Author

tagliala commented Oct 3, 2022

Failures depend on Rails Edge compatibility

@tagliala tagliala merged commit 83493f6 into master Oct 3, 2022
@tagliala tagliala deleted the bugfix/fix-in-batches-support branch October 3, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

find_each, find_in_batches batch processing not honored in history model
1 participant