Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure structure dump includes Chronomodel schemas #135

Merged
merged 1 commit into from
Feb 13, 2022

Conversation

tagliala
Copy link
Member

@tagliala tagliala commented Feb 7, 2022

When schema_search_path option is specified, structure dump may
exclude Chronomodel schemas if they have not been included in the
Configuration.

This change ensures that extra arguments are passed to the command line
to include required schemas

Fix: #134

@tagliala tagliala force-pushed the bugfix/fix-schema-search-path-134 branch 2 times, most recently from 8f9f257 to 348d992 Compare February 13, 2022 13:48
@tagliala tagliala marked this pull request as ready for review February 13, 2022 14:04
@tagliala tagliala force-pushed the bugfix/fix-schema-search-path-134 branch 2 times, most recently from b0599e4 to a7c20aa Compare February 13, 2022 17:21
@tagliala tagliala marked this pull request as draft February 13, 2022 17:21
When `schema_search_path` option is specified, structure dump will
exclude Chronomodel schemas in AR >= 6.1 because the new configuration
options `configuration_hash` is not being patched

Fix: #134
@tagliala tagliala force-pushed the bugfix/fix-schema-search-path-134 branch from a7c20aa to 21863bc Compare February 13, 2022 18:48
@tagliala tagliala marked this pull request as ready for review February 13, 2022 19:00
@tagliala tagliala merged commit 8bac8a8 into master Feb 13, 2022
@tagliala tagliala deleted the bugfix/fix-schema-search-path-134 branch February 13, 2022 19:14
@tagliala
Copy link
Member Author

ciao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chronomodel ignores schema_search_path configuration
1 participant