Check module inclusion instead of respond_to? #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
force-pushed
the
bugfix/fix-stack-overflow-with-delegate-missing-to-131
branch
from
7c9ab29 to
c7cdc6d
Compare
Checks if the module `AsOfTimeHolder` is included in the model rather than using `respond_to?` to prevent stack overflow when a model delegates missing methods to an association. Fix #131
tagliala
force-pushed
the
bugfix/fix-stack-overflow-with-delegate-missing-to-131
branch
from
c7cdc6d to
b115bac
Compare
tagliala
deleted the
bugfix/fix-stack-overflow-with-delegate-missing-to-131
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if the module
AsOfTimeHolderis included in the model ratherthan using
respond_to?to prevent stack overflow when a modeldelegates missing methods to an association.
Fix #131