Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to ActiveRecord 7.0 #113

Merged
merged 6 commits into from
Dec 16, 2021
Merged

Add support to ActiveRecord 7.0 #113

merged 6 commits into from
Dec 16, 2021

Conversation

gridanjbf
Copy link
Contributor

No description provided.

@gridanjbf gridanjbf requested a review from tagliala November 5, 2021 16:57
@gridanjbf gridanjbf marked this pull request as draft November 5, 2021 16:58
@gridanjbf gridanjbf changed the title Feature/ar 70 - Feature/ar 70 - PeopleV2 Nov 5, 2021
@gridanjbf gridanjbf force-pushed the feature/ar-70 branch 7 times, most recently from 3271579 to 53040cd Compare November 16, 2021 08:53
@gridanjbf gridanjbf marked this pull request as ready for review November 16, 2021 08:54
.github/workflows/ruby.yml Outdated Show resolved Hide resolved
.github/workflows/ruby.yml Outdated Show resolved Hide resolved
.github/workflows/ruby.yml Outdated Show resolved Hide resolved
.github/workflows/ruby.yml Outdated Show resolved Hide resolved
spec/aruba/fixtures/railsapp/config/initializers/assets.rb Outdated Show resolved Hide resolved
lib/chrono_model/patches/relation.rb Show resolved Hide resolved
Rakefile Outdated Show resolved Hide resolved
lib/chrono_model/patches/relation.rb Outdated Show resolved Hide resolved
@tagliala tagliala marked this pull request as draft November 23, 2021 22:00
@tagliala tagliala changed the title Feature/ar 70 - PeopleV2 AR 7.x - PeopleV2 Nov 23, 2021
@tagliala
Copy link
Member

@gridanjbf I've rebased from master and cleaned up the commits

Meanwhile, something changed in ruby edge and

Don't know how to build task 'db:structure:load' (See the list of available tasks with `rake --tasks`)
       Did you mean?  db:test:load

rspec ./spec/aruba/rake_task_spec.rb:11 # rake tasks bundle exec rake -T is expected to have output: /db:structure:load/
rspec ./spec/aruba/rake_task_spec.rb:62 # rake tasks db:structure:load given a file db/structure.sql with default username and password is expected to be successfully executed
rspec ./spec/aruba/rake_task_spec.rb:68 # rake tasks db:structure:load given a file db/structure.sql without a specified username and password is expected to be successfully executed

The old branch is available here and specs are failing there too

@tagliala
Copy link
Member

Ref: rails/rails@cf269d5

@gridanjbf gridanjbf force-pushed the feature/ar-70 branch 2 times, most recently from 180e0b2 to 3dfb671 Compare November 24, 2021 16:32
spec/support/aruba.rb Outdated Show resolved Hide resolved
Rakefile Outdated Show resolved Hide resolved
Rakefile Outdated Show resolved Hide resolved
@tagliala tagliala changed the title AR 7.x - PeopleV2 Add support to ActiveRecord 7.0 Dec 16, 2021
Rakefile Outdated Show resolved Hide resolved
Rakefile Show resolved Hide resolved
@tagliala tagliala marked this pull request as ready for review December 16, 2021 13:45
@tagliala tagliala merged commit 8925fcc into master Dec 16, 2021
@tagliala tagliala deleted the feature/ar-70 branch December 16, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants