Fix CodeClimate test coverage #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
force-pushed
the
bugfix/fix-codeclimate-coverage
branch
from
26578d8 to
298461f
Compare
|
Is then gem.add_development_dependency 'codeclimate-test-reporter'still required in |
|
Good catch. I think it is not needed and it has also been deprecated Ref: https://github.com/codeclimate/ruby-test-reporter |
tagliala
force-pushed
the
bugfix/fix-codeclimate-coverage
branch
from
298461f to
05929bc
Compare
|
Ok, we are affected by codeclimate/test-reporter#418 |
tagliala
force-pushed
the
bugfix/fix-codeclimate-coverage
branch
3 times, most recently
from
32ec6eb to
764ae94
Compare
Remove the deprecated `codeclimate-test-reporter` gem and follow new instructions for Travis CI provided by Code Climate Ref: - https://github.com/codeclimate/ruby-test-reporter - https://docs.codeclimate.com/docs/travis-ci-test-coverage
tagliala
force-pushed
the
bugfix/fix-codeclimate-coverage
branch
from
764ae94 to
a027e6f
Compare
|
|
|
🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OT: Why travis does not run tests on other branches different than master?
Answering myself:
Enabled