chore: replace config map with external secret for ietfweb #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 153 153
Lines 3293 3293
=======================================
Hits 3164 3164
Misses 129 129 ☔ View full report in Codecov by Sentry. |
|
I will use this branch for testing in staging (the reason the PR is currently in draft), but in the meantime, feel free to point out if there is any obvious mistake. |
kesara
reviewed
Aug 22, 2024
kesara
approved these changes
Aug 22, 2024
NGPixel
requested changes
Aug 22, 2024
NGPixel
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #481