Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix issue without traling slash. (#499) #500

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

kesara
Copy link
Member

@kesara kesara commented Aug 15, 2024

If a location is defined by a prefix string that ends with the slash character, and requests are processed by one of proxy_pass, fastcgi_pass, uwsgi_pass, scgi_pass, memcached_pass, or grpc_pass, then the special processing is performed. In response to a request with URI equal to this string, but without the trailing slash, a permanent redirect with the code 301 will be returned to the requested URI with the slash appended.

http://nginx.org/en/docs/http/ngx_http_core_module.html#location

Also see: https://nginx.org/en/docs/http/ngx_http_autoindex_module.html
ngx_http_autoindex_module expects a trailing /.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (c335d04) to head (0f15653).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #500   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files         153      153           
  Lines        3293     3293           
=======================================
  Hits         3164     3164           
  Misses        129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kesara kesara requested a review from microamp August 20, 2024 21:11
@kesara kesara merged commit 4f5cdb1 into main Aug 20, 2024
13 checks passed
@kesara kesara deleted the trailing-slash branch August 20, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants