-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improve test coverage #395
chore: Improve test coverage #395
Conversation
I've pushed an update to cover IAB-specific pages too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Alex, just have a few comments, and something to consider for the tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #395 +/- ##
===========================================
+ Coverage 82.72% 95.89% +13.16%
===========================================
Files 124 143 +19
Lines 2599 3117 +518
===========================================
+ Hits 2150 2989 +839
+ Misses 449 128 -321 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are looking good to me, I just want more documentation. :)
Also flagging a small concern about coupling the BE and FE a bit more tightly with the tests.
@SharmaineLim I've added more docstrings and comments. I've also updated |
Fix #378.
OrderedSet
implementation).date_to
URL parameter incorrectly.# pragma: no cover
because they are impractical / not useful to test.