fix: Generate local URLs for megamenu and skip empty links #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs. #326
I was testing what happens when a page from the megamenu is deleted, something I'd skipped over in the main PR, and found a couple of related issues.
With this change, if a page is deleted, its link becomes empty, and it will be skipped when rendering the menu.
This PR also makes local development slightly easier: in the megamenu, links to pages will be generated as local URLs, so that they point to localhost instead of www.ietf.org.
Additionally, after applying the utils.0009_megamenu migration, I suggest running
./manage.py rebuild_references_index. This way, when deleting a page that is part of the megamenu, the CMS will include theMainMenuItemobject in its list of references. (References are normally kept up to date, but when creating content through migrations, the relevant hook doesn't get called.)