Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty author organization name #3

Open
strogonoff opened this issue Feb 16, 2022 · 11 comments
Open

Empty author organization name #3

strogonoff opened this issue Feb 16, 2022 · 11 comments
Labels
bug Something isn't working

Comments

@strogonoff strogonoff changed the title Empty organization name Empty author organization name Feb 16, 2022
@strogonoff strogonoff added the bug Something isn't working label Feb 17, 2022
strogonoff referenced this issue in ietf-tools/bibxml-service Mar 17, 2022
@ronaldtse
Copy link

This is a data error. We have to update this entry manually since it is a static entry.

@ronaldtse
Copy link

And in this case the publisher isn’t IETF, it’s IEEE.

@ronaldtse
Copy link

Unless we are to distinguish the publisher of the bibliographic item entry vs the publisher of the information resource… but that is not supported by Relaton.

@strogonoff
Copy link
Author

strogonoff commented Mar 21, 2022

Unless we are to distinguish the publisher of the bibliographic item entry vs the publisher of the information resource… but that is not supported by Relaton.

Yeah, I think this is a useful distinction to make.

There are three levels of metadata that we could be dealing with, of which Relaton covers two:

  1. Relaton source bibliographic item metadata (examples: fetched describes when item was read from the authoritative source, and maybe a couple of properties like id and doctype are technically Relaton source specific)
  2. authoritative source bibliographic item metadata
  3. actual document metadata (= bibliographic item data; this is all other properties I think: who published the document, who authored/edited it, etc.)

If we wanted to cover “bibliographic item publisher”, it would come at level 2, but we currently have no properties of the sort.

As a side note, I think Relaton structure could do a better job at separating levels 1 and 3, e.g. by segregating them more cleanly under nested keys. Not that it’s critical…

@strogonoff
Copy link
Author

strogonoff commented Mar 21, 2022

Regarding publisher being wrong, this may be related to https://github.com/ietf-ribose/relaton-data-misc/issues/2

@strogonoff
Copy link
Author

A possibly related issue—empty affiliated organization name:

- en
affiliation:
- organization:
name:
- "\n "

@ronaldtse
Copy link

@andrew2net can you have a look? This seems to be an issue.

@andrew2net
Copy link
Contributor

andrew2net commented Jul 28, 2022

The source has an empty <organization></organization> elements. Suppose we should skip these organisation, don't we?

@ronaldtse
Copy link

@andrew2net yes we should just remove the elements that are empty.

andrew2net added a commit to relaton/relaton-bib that referenced this issue Jul 29, 2022
@andrew2net
Copy link
Contributor

@ronaldtse @strogonoff fixed but the repo will be updated later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants