-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add number of partitipants to polls #1
Conversation
alexamirante
commented
Sep 4, 2024
- Add the total number of participants to the poll to the related panel
- Update dependencies to fix security vulnerabilities
- Fix a few graphical glitches
"version": "3.0.2", | ||
"resolved": "https://registry.npmjs.org/braces/-/braces-3.0.2.tgz", | ||
"integrity": "sha512-b8um+L1RzM3WDSzvhm6gIz1yfTbBt6YTlcEKAvsmqCZZFw46z626lVj9j1yEPW33H5H+lBQpZMP1k8l+78Ha0A==", | ||
"version": "3.0.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we updating the package-lock.json
when package.json
hasn't changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm audit fix
changed that to fix a vulnerability in one of the sub-dependencies (which are not listed in package.json)
return <Tab key={i}>{panel.title}</Tab>; | ||
return ( | ||
<Tab key={i}> | ||
{panel.title === "Show of hands" ? "Polls" : panel.title} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make "Show of hands"
a constant