fix: only send state change notifications once #7953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids sending multiple copies of a state change notification to a
CommunityList
subscriber. This is accomplished by checking whethercreated
isTrue
in the call to our signal handler. (Relevant Django docs)Refactors the rfceditor sync code where we were triggering the double notifications to do its updates before the
save()
call.The refactoring would resolve the issue without the check of the
created
flag in our signal handler, but I think the guard is worth it. I did a fairly thorough but probably not exhaustive skim for other places where we might save a DocEvent twice and did not find any.