Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize and debug has_role and can_manage_some_groups #7949

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

rjsparks
Copy link
Member

No description provided.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (c7f6bde) to head (1405039).
Report is 75 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7949      +/-   ##
==========================================
+ Coverage   88.78%   88.83%   +0.04%     
==========================================
  Files         296      304       +8     
  Lines       41320    41510     +190     
==========================================
+ Hits        36687    36875     +188     
- Misses       4633     4635       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits

ietf/group/utils.py Outdated Show resolved Hide resolved
ietf/group/utils.py Outdated Show resolved Hide resolved
ietf/group/utils.py Outdated Show resolved Hide resolved
@rjsparks rjsparks merged commit 8362b45 into ietf-tools:main Sep 17, 2024
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants