refactor: helper for session recording URL; fix test #7933
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks up the
Session.session_recording_url()
method using a helper method to simplify the test, then refactors those tests to avoid the faulty assumption that the UTC timestamp of a session will be on the same numerical date as the meeting (which is in meeting-local time).Useful factoid when reviewing:
f"{t:%Y%m%d-%H%M}" == f"{t.strftime('%Y%m%d-%H%M')}"
)