feat: is_authenticated request logging + cleanup #7893
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal here is adding the
is_authenticated
field to gunicorn logs for the datatracker. This is done by adding anX-Datatracker-Is-Authenticated
header to the response. This is used by the gunicorn logs, then stripped out by nginx.On dev systems, this header will be reported. We could strip it out there as well, but it seems harmless to me.
Also does a little logging cleanup
X-Real-IP
header and logging, which we're not using and is unlikely to be usefulduration_ms
toduration_s
and logs seconds, both for nginx and gunicorn. Before this, nginx was logging seconds with an incorrect label. Gunicorn was logging ms correctly, but for simplicity this keeps them in the same units. (Both are fractional, so either 1.234 or 1.234000, will show up in the logs)