Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use meetecho-player.ietf.org for session recording #7873

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

kesara
Copy link
Member

@kesara kesara commented Aug 29, 2024

No description provided.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.78%. Comparing base (c7f6bde) to head (3df4a31).
Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7873      +/-   ##
==========================================
- Coverage   88.78%   88.78%   -0.01%     
==========================================
  Files         296      304       +8     
  Lines       41320    41452     +132     
==========================================
+ Hits        36687    36802     +115     
- Misses       4633     4650      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks
Copy link
Member

One issue (as I understand what we're currently doing and where this is headed) is that we'll produce links to this player for interms that didn't use meetecho (like moq). Can we add knowing if there's a meetecho recording to the database?

Perhaps when a recording is pushed, the datatracker also gets an api hit that sets a bit on the relevant session?

Or, less optimal, the datatracker looks to see if a recording exists before providing the URL?

@kesara kesara marked this pull request as ready for review September 3, 2024 10:53
Copy link
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we need to make the datatracker aware of whether a recording exists before we provide a link to it. Created #7888

@rjsparks rjsparks merged commit 23e5307 into ietf-tools:main Sep 3, 2024
9 checks passed
@kesara kesara deleted the feat/meetecho-player branch September 6, 2024 22:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants