Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mark bofreqs as spam #7869

Merged
merged 1 commit into from
Aug 28, 2024
Merged

feat: mark bofreqs as spam #7869

merged 1 commit into from
Aug 28, 2024

Conversation

rjsparks
Copy link
Member

@rjsparks rjsparks commented Aug 28, 2024

This is an incremental improvement, allowing the bofreqs to be marked as spam. A future enhancement will gate bofreqs so spam bofreqs are never accepted in the first place.

Note that this does not delete the bofreq marked as spam - it only causes it to not appear on the bofreq listing (unless logged in as the secretariat where it will still show, but in a spam section). The spam-marked bofreq will still be available if its name is known.

cc: @cindymorgan

Fixes #7862

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.78%. Comparing base (c7f6bde) to head (45cf612).
Report is 50 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7869      +/-   ##
==========================================
- Coverage   88.78%   88.78%   -0.01%     
==========================================
  Files         296      303       +7     
  Lines       41320    41430     +110     
==========================================
+ Hits        36687    36784      +97     
- Misses       4633     4646      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit 1f6db0f into ietf-tools:main Aug 28, 2024
9 checks passed
@rjsparks rjsparks deleted the bofreqspam branch August 28, 2024 19:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Secretariat to delete obvious spam BOF requests
2 participants