Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Install weasyprint as a xml2rfc extra #7845

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

kesara
Copy link
Member

@kesara kesara commented Aug 22, 2024

Since xml2rfc v3.23.0, WeasyPrint version is pinned.

This will also enforce the pydyf version1.

Footnotes

  1. https://github.com/ietf-tools/xml2rfc/blob/main/setup.cfg#L59-L60

Since xml2rfc v3.23.0, WeasyPrint version is pinned.
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (c7f6bde) to head (a0ac21b).
Report is 42 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7845      +/-   ##
==========================================
+ Coverage   88.78%   88.80%   +0.01%     
==========================================
  Files         296      303       +7     
  Lines       41320    41427     +107     
==========================================
+ Hits        36687    36790     +103     
- Misses       4633     4637       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks
Copy link
Member

I thought about dropping the explicit declaration of weasyprint from datatracker's requirements, relying on inheriting it from xml2rfc (to avoid some future update of the versions we require, perhaps coming in by automation, from breaking against the pin in xml2rfc), but making it obvious we have the dependency (for more than xml2rfc) is worth that maintenance burden.

@rjsparks rjsparks merged commit 9b4671c into ietf-tools:main Aug 22, 2024
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants