Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused notes field from SchedSessTimeAssignment model #7832

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

rjsparks
Copy link
Member

It's unclear what this column was ever intended to contain. All current objects have either None or "" for values. I've scrubbed the python for any use and haven't found any. Another careful pass, looking particularly for use in the js driving the agenda editing pages, would be prudent.

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (c7f6bde) to head (1ad0372).
Report is 40 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #7832    +/-   ##
========================================
  Coverage   88.78%   88.79%            
========================================
  Files         296      303     +7     
  Lines       41320    41428   +108     
========================================
+ Hits        36687    36785    +98     
- Misses       4633     4643    +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me - I don't see any use of the field in js, vue, or html files.

@rjsparks rjsparks merged commit f53d1ca into ietf-tools:main Aug 21, 2024
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2024
@rjsparks rjsparks deleted the remove_stsa_notes branch September 16, 2024 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants