Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unify slide upload and proposal #7787

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

jimfenton
Copy link
Collaborator

This removes the propose_session_slides page, URL, and view function and merges them into upload_session_slides. It adds a checkbox, visible to chairs, allowing them to propose, rather than automatically approve, slides they are submitting.

Fixes #7705
Fixes #7178

The tests still have separate test_upload_slides and test_propose_session_slides functions. Some of this may be redundant, but I thought it better to do possibly overtest. Perhaps the tests should be combined as well.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.78%. Comparing base (c7f6bde) to head (6879762).
Report is 23 commits behind head on main.

Files Patch % Lines
ietf/meeting/views.py 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7787      +/-   ##
==========================================
- Coverage   88.78%   88.78%   -0.01%     
==========================================
  Files         296      296              
  Lines       41320    41322       +2     
==========================================
+ Hits        36687    36688       +1     
- Misses       4633     4634       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rjsparks
rjsparks previously approved these changes Aug 5, 2024
@rjsparks rjsparks merged commit 9ef7bff into ietf-tools:main Aug 6, 2024
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants