feat: Agenda URL #hash scrolls to 'now' or specific day #7772
Conversation
holloway
force-pushed
the
feat/agenda-scroll-to-now
branch
from
251fb76
to
a852d9e
Compare
| @@ -206,8 +206,6 @@ function scrollToDay (dayId, ev) { | |||
| } | |||
|
|
|||
| function scrollToNow (ev) { | |||
| ev.preventDefault() | |||
There was a problem hiding this comment.
Removed so that when clicking 'Now' <a href="#now">Now</a>
...it will update the browser location with #now so that future reloads will have a hashstate that expresses 'Now'
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7772 +/- ##
==========================================
+ Coverage 88.78% 88.79% +0.01%
==========================================
Files 296 303 +7
Lines 41320 41422 +102
==========================================
+ Hits 36687 36782 +95
- Misses 4633 4640 +7 ☔ View full report in Codecov by Sentry. |
holloway
changed the title
holloway
changed the title
…ker into feat/agenda-scroll-to-now
|
This is looking good on desktop, but on screens the size of an iphone 11, its not acting as intended. With the dev code uncommented, looking in this view, the now link doesn't change what's in the url bar, and pasting http://localhost:8000/meeting/agenda/#now into a blank tab doesn't cause the viewport to move to the red line. |
|
@rjsparks the functionality should work now. I still need to fix the tests. |
|
@rjsparks fixed. ready for review |
…ings panel for debugging
Fixes #7245
Allows scrolling to either
#nowor#agenda-day-YYYY-MM-DDon page load.Adds a developer-only utility to modify server agenda dates to be the same as local browser time, so that the 'Now' button is available.