fix: Sort RFCs by date #7766
Merged
fix: Sort RFCs by date #7766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NGPixel
previously approved these changes
Jul 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7766 +/- ##
==========================================
- Coverage 88.78% 88.77% -0.01%
==========================================
Files 296 296
Lines 41320 41337 +17
==========================================
+ Hits 36687 36698 +11
- Misses 4633 4639 +6 ☔ View full report in Codecov by Sentry. |
jennifer-richards
previously approved these changes
Jul 30, 2024
| @@ -5,8 +5,10 @@ import { | |||
| function text_sort(a, b, options) { | |||
|
|
|||
| function prep(e, options) { | |||
| return $($.parseHTML(e.values()[options.valueName])) | |||
| .text() | |||
| const el = $($.parseHTML(e.values()[options.valueName])); | |||
jennifer-richards
approved these changes
Jul 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7740
Allows sorting by
data-sort-numberattribute on the cell, rather than by the content of the cell which might be formatted.