feat: recognize HTTPS via proxy #7765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjsparks
approved these changes
Aug 1, 2024
|
For the record: we've successfully confirmed Cloudflare's |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will cause Django to treat HTTPS connections to CloudFlare as secure. This will cause it to generate
https://...URLs when generating absolute URLs despite seeing non-TLS proxied requests.Before deploying this, we should confirm that CloudFlare is behaving as required in the warning at https://docs.djangoproject.com/en/dev/ref/settings/#secure-proxy-ssl-header. We also need to be sure we never deploy this setting without a proxy that handles the
X-Forwarded-Protoheader as required.