Add copyrights #7725
Open
Add copyrights #7725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script does basic copyright notice checks, and will be used to add the necessary features in issue ietf-tools#7690.
feat: Read list of files to check/change from argv[] fix: Also exit with a valid return status fix: Move ZIP check into process(), so you can put foo.zip into a -f usage.
Also Use -v flag in CI
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7725 +/- ##
=======================================
Coverage 88.78% 88.78%
=======================================
Files 296 296
Lines 41320 41330 +10
=======================================
+ Hits 36687 36696 +9
- Misses 4633 4634 +1 ☔ View full report in Codecov by Sentry. |
These are files that did not end with a newline, so add the copyright line by hand.
richsalz
force-pushed
the
add-copyrights
branch
from
6291871
to
b1c9aeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dependant on #7717. It adds a script to add copyrights, and includes a commit to manually add them to some particularly troublesome files.
Think of this as WIP, because this PR does not include the changes for the rest of the files that don't have a copyright. You can run the ietf/add-copyright script by hand and review the changes.