Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use area-acronym-at-the-time in proceedings #7723

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

russhousley
Copy link
Collaborator

When generating IETF meeting proceedings, use the Area Acronym for each WG at the time of the meeting. Fixes #7706.

When generating IETF meeting proceedings, use the Area Acronym for each WG at the time of the meeting. Fixes ietf-tools#7706.
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.79%. Comparing base (187c2c5) to head (4851457).
Report is 341 commits behind head on main.

Files Patch % Lines
ietf/meeting/views.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7723      +/-   ##
==========================================
- Coverage   88.98%   88.79%   -0.19%     
==========================================
  Files         291      296       +5     
  Lines       40717    41331     +614     
==========================================
+ Hits        36233    36701     +468     
- Misses       4484     4630     +146     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jennifer-richards jennifer-richards changed the title Fix #7706 fix: use area-acronym-at-the-time in proceedings Jul 22, 2024
Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me like it's working. It's adding 15-20% more queries to the proceedings calculation (for 119, it adds about 500 to the already very large query count of 2840 when rendering the page).

I suspect we can improve the cost of this change, but better to look at it in the big picture than to dig deep on it now.

@rjsparks rjsparks merged commit 63d1307 into ietf-tools:main Aug 5, 2024
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Area names are not correct for renamed areas in proceedings
3 participants