Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Explicitly set executable_path for Selenium #7715

Merged
merged 3 commits into from
Jul 21, 2024

Conversation

larseggert
Copy link
Collaborator

So it finds geckodriver again.

ietf/utils/jstest.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.79%. Comparing base (b00dfd3) to head (ee16ba1).
Report is 10 commits behind head on main.

Files Patch % Lines
ietf/utils/jstest.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7715   +/-   ##
=======================================
  Coverage   88.79%   88.79%           
=======================================
  Files         296      296           
  Lines       41319    41320    +1     
=======================================
+ Hits        36688    36689    +1     
  Misses       4631     4631           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit 363c01e into ietf-tools:main Jul 21, 2024
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants