feat: Expose important library versions #7713
Open
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rjsparks is this implementation going in the correct direction? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7713 +/- ##
==========================================
+ Coverage 88.78% 88.92% +0.13%
==========================================
Files 296 304 +8
Lines 41320 41332 +12
==========================================
+ Hits 36687 36754 +67
+ Misses 4633 4578 -55 ☔ View full report in Codecov by Sentry. |
|
Yes - these seems reasonable. |
|
@kesara - do you want to continue to pursue this? |
Yes. I will. Sorry, I missed your reply during meeting. |
Update `/api/version` to include
```
"other": {
"xml2rfc": "<version>",
"weasyprint": "<version>"
},
```
Fixes ietf-tools#3415
rjsparks
reviewed
Nov 5, 2024
| @@ -1279,6 +1279,8 @@ def skip_unreadable_post(record): | |||
|
|
|||
| PUBLISH_IPR_STATES = ['posted', 'removed', 'removed_objfalse'] | |||
|
|
|||
| IMPORTANT_LIBRARIES = ["django", "celery", "lxml", "markdown", "psycopg2", "pyang", "rfc2html", "weasyprint", "xml2rfc"] | |||
There was a problem hiding this comment.
Lets have a group conversation this week about the content of this list.
There was a problem hiding this comment.
Missed this week - aim for next - added a card
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
/api/versionto includeFixes #3415