Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fewer ipr bounce alerts #7553

Merged

Conversation

jennifer-richards
Copy link
Member

This should send IPR delivery failed alerts to the admins in the same circumstances that the old management command did. I.e., it will only send the alert on an unhandled exception, not on any failure to accept the IPR message.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.93%. Comparing base (187c2c5) to head (d737bc2).
Report is 244 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7553      +/-   ##
==========================================
- Coverage   88.98%   88.93%   -0.06%     
==========================================
  Files         291      295       +4     
  Lines       40717    41242     +525     
==========================================
+ Hits        36233    36679     +446     
- Misses       4484     4563      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit 2a90447 into ietf-tools:main Jun 17, 2024
9 checks passed
@jennifer-richards jennifer-richards deleted the less-angsty-ipr-responses branch June 18, 2024 01:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants