feat: better reject null characters in forms #7472
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces Django's
forms.ModelMultipleChoiceField
with a subclass that applies theProhibitNullCharactersValidator
to the submitted values before calling the superclassclean()
method. This works around an apparent bug in Django that causes it to throw a server error instead of properly marking the form as invalid.We've mostly seen this abused in the
SearchForm
, but I've preemptively replaced all our use of the field class.