Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exception if submission files missing #7458

Merged
merged 1 commit into from
May 24, 2024

Conversation

jennifer-richards
Copy link
Member

This allows an exception to be raised if submission files are missing, leading to a server error. That's not pretty, but is better than ignoring the fail.

This allows an exception to be raised if submission
files are missing, leading to a server error. That's
not pretty, but is better than ignoring the fail.
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.93%. Comparing base (187c2c5) to head (8b10ee9).
Report is 209 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7458      +/-   ##
==========================================
- Coverage   88.98%   88.93%   -0.06%     
==========================================
  Files         291      294       +3     
  Lines       40717    41175     +458     
==========================================
+ Hits        36233    36618     +385     
- Misses       4484     4557      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit a1a3097 into ietf-tools:main May 24, 2024
9 checks passed
@jennifer-richards jennifer-richards deleted the move-files-exception branch May 24, 2024 16:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants