feat: discourage URLs in Person names #7453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ has long been disallowed via validation in the views and "/" has been disallowed for the name field via a validator. This adds @ and : to the validator and applies it to the name, plain, ascii, and ascii_short fields. This should apply everywhere we use a ModelForm.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7453 +/- ##
==========================================
- Coverage 88.98% 88.91% -0.08%
==========================================
Files 291 294 +3
Lines 40717 41158 +441
==========================================
+ Hits 36233 36594 +361
- Misses 4484 4564 +80 ☔ View full report in Codecov by Sentry. |
rjsparks
approved these changes
May 22, 2024
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disallows
@,:, and/in thePerson.name,.plain,.ascii, and.ascii_shortfields via a validator on the model field. The aim is to make it harder for bad actors to stuff a URL in one of these fields.