Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move document state help to /doc #7206

Merged
merged 6 commits into from
Mar 22, 2024

Conversation

jimfenton
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.94%. Comparing base (187c2c5) to head (9c7d81d).
Report is 77 commits behind head on main.

❗ Current head 9c7d81d differs from pull request most recent head 682695c. Consider uploading reports for the commit 682695c to get more accurate results

Files Patch % Lines
ietf/help/views.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7206      +/-   ##
==========================================
- Coverage   88.98%   88.94%   -0.05%     
==========================================
  Files         291      291              
  Lines       40717    41062     +345     
==========================================
+ Hits        36233    36522     +289     
- Misses       4484     4540      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jim - this is great and gets most of the way there, but we need to touch a few things before bringing this into main.

ietf/help/views.py Show resolved Hide resolved
ietf/doc/views_help.py Show resolved Hide resolved
ietf/help/views.py Outdated Show resolved Hide resolved
@jimfenton
Copy link
Collaborator Author

Also noticed that doc/help/state/draft-iana/ now returns a 404. /help/state/draft/iana/ didn't produce a very useful page before, but at least it didn't generate a 404.

@rjsparks
Copy link
Member

rjsparks commented Mar 22, 2024

Also noticed that doc/help/state/draft-iana/ now returns a 404. /help/state/draft/iana/ didn't produce a very useful page before, but at least it didn't generate a 404.

Interesting catch - draft-iana isn't a document state type. I think that it passing through the URLs to date was a bug.

(edit): It is a StateType, but shouldn't be - the StateType is unused. I'll track removing that StateType object separately.

>>> StateType.objects.filter(slug__icontains="iana")
<QuerySet [<StateType: draft-iana>, <StateType: draft-iana-action>, <StateType: draft-iana-review>, <StateType: draft-iana-experts>]>
>>> Counter(State.objects.filter(type__slug__contains="iana").values_list("type_id",flat=True))
Counter({'draft-iana-action': 9, 'draft-iana-review': 5, 'draft-iana-experts': 4})

@rjsparks
Copy link
Member

I've deleted the unused StateType in production using the admin.

@rjsparks rjsparks merged commit 891c0e9 into ietf-tools:main Mar 22, 2024
6 of 7 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants