-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add celery tasks for idnits2 and bibxml file generation #7204
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7204 +/- ##
==========================================
- Coverage 88.98% 88.79% -0.20%
==========================================
Files 291 296 +5
Lines 40717 41312 +595
==========================================
+ Hits 36233 36682 +449
- Misses 4484 4630 +146 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo, one small change I think we should make.
ietf/doc/utils.py
Outdated
write_bibxml_file_if_changed(ref_rev_file_name, bibxml) | ||
except Exception as ee: | ||
log.log('\n%s-%s: %s\n' % (e.doc.name, e.doc.rev, str(ee))) | ||
raise ee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and in bibxml_for_recent_drafts()
, the re-raise of the exception is a change from the management command. In those, the exception was written to stderr and the script continued. The change means that the task will stop after an error.
I think we want to keep the old behavior (i.e., remove the raise ee
here and on line 1299). I hope this doesn't contradict something we discussed at the code sprint. @russhousley do you recall?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds fine to me.
ietf/doc/tests_tasks.py
Outdated
content = f.read() | ||
self.assertIn(draft.title, content) | ||
|
||
def test_generate_bibxml_files_for_recent_drafts_task_with_bad_vakue(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: vakue
-> value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goof catch. I read past it many times.
Fix typo: bad_vakue -> bad_value
Don't raise error inbibxml_for_all_drafts
# Conflicts: # ietf/doc/tasks.py # ietf/doc/tests_tasks.py
In the scramble to cut over to the new infrastructure, I lost track of this PR and wound up reimplementing it slightly differently. I'm merging that over so we can merge this. |
Add celery tasks for idnits2 and bibxml file generation. Fixes #7192