Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing button text for PostScript #7200

Merged
merged 8 commits into from
Mar 20, 2024
Merged

Conversation

evyncke
Copy link
Contributor

@evyncke evyncke commented Mar 16, 2024

This fixes #6900 by avoiding any Postscript file in the list of built URL for a document,

@evyncke evyncke mentioned this pull request Mar 16, 2024
1 task
ietf/doc/utils.py Outdated Show resolved Hide resolved
@evyncke
Copy link
Contributor Author

evyncke commented Mar 16, 2024

Note: I was unable to fully test it as my docker environment does not have the full archived drafts, but add empty draft-ietf-tsvwg-quickstart-07.ps/txt/pdf locally and it works (i.e., txt/pdf buttons are displayed and nothing for ps)

Co-authored-by: Robert Sparks <[email protected]>
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.94%. Comparing base (187c2c5) to head (b31e446).
Report is 64 commits behind head on main.

❗ Current head b31e446 differs from pull request most recent head 4478125. Consider uploading reports for the commit 4478125 to get more accurate results

Files Patch % Lines
ietf/doc/utils.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7200      +/-   ##
==========================================
- Coverage   88.98%   88.94%   -0.05%     
==========================================
  Files         291      291              
  Lines       40717    41069     +352     
==========================================
+ Hits        36233    36528     +295     
- Misses       4484     4541      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit faa3efd into ietf-tools:main Mar 20, 2024
7 checks passed
@evyncke evyncke deleted the fix-6900 branch March 21, 2024 06:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing button text for PostScript
3 participants