Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Show recordings for interims #7197

Merged
merged 8 commits into from
Aug 7, 2024
Merged

fix: Show recordings for interims #7197

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1fb3b40
fix: Show recordings for interims
richsalz Mar 16, 2024
c03f9b4
style: Use "is not" and "is" for None comparisons
richsalz Jul 29, 2024
ab9ae1b
None comparison and non-IETF meetings
richsalz Jul 29, 2024
ea28b5a
fix: Restore useNotes for JS fields
richsalz Aug 2, 2024
44d426c
fix: uses_notes->useNotes (in JavaScript)
richsalz Aug 5, 2024
29817a8
Missed a uses_notes->useNotes edit
richsalz Aug 6, 2024
4e8ce54
fix: useNotes->usesNotes
jennifer-richards Aug 6, 2024
9c1dd11
Merge remote-tracking branch 'ietf-tools/main' into fix-6543
rjsparks Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ietf/meeting/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,17 +385,19 @@ def uses_notes(self):
if self.type_id != 'ietf':
return True
num = self.get_number()
return num != None and num >= 108
return num is not None and num >= 108

def has_recordings(self):
if self.type_id != 'ietf':
return True
num = self.get_number()
return num != None and num >= 80
return num is not None and num >= 80

def has_chat_logs(self):
if self.type_id != 'ietf':
return True;
rjsparks marked this conversation as resolved.
Show resolved Hide resolved
num = self.get_number()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For symmetry with the other has_* methods, I think it'd be good to make clear how this behaves with non-"ietf" meetings

return num != None and num >= 60
return num is not None and num >= 60

def meeting_start(self):
"""Meeting-local midnight at the start of the meeting date"""
Expand Down